Create at::linear #10755
Closed
Create at::linear #10755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldsborough
requested review from
apaszke,
colesbury,
ebetica,
ezyang,
gchanan,
soumith and
zdevito
as code owners
li-roy
reviewed
Aug 21, 2018
| 'arange.*', 'range.*', '_gesv.*', '_getri.*', 'slice', | ||
| '_local_scalar', '_local_scalar_dense', | ||
| 'max_pool1d', 'max_pool2d', 'max_pool3d' | ||
| 'max_pool1d', 'max_pool2d', 'max_pool3d', 'linear' |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
Hey this seems to have broken ONNX export: https://ci.pytorch.org/jenkins/job/caffe2-builds/job/onnx-py2-gcc5-ubuntu16.04-test/2643/console I can try writing up a symbolic real quick |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 22, 2018
Summary: The optimized code for `linear()` which uses `addmm` when a bias is given was duplicated three times in the ATen and the C++ API. Let's just have `at::linear` and use that everywhere. apaszke ezyang (who mentioned this in #10481) Pull Request resolved: pytorch/pytorch#10755 Differential Revision: D9443881 Pulled By: goldsborough fbshipit-source-id: a64862d1649b5961043d58401625ec267d97d9f3
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 24, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 25, 2018
Summary: Resubmission of pytorch/pytorch#10755 with fix for ONNX ezyang jamesr66a Pull Request resolved: pytorch/pytorch#10799 Differential Revision: D9482168 Pulled By: goldsborough fbshipit-source-id: 85d4bdfcf0d451f2e7a1c83c5f5415cdd6caacdc
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: The optimized code for `linear()` which uses `addmm` when a bias is given was duplicated three times in the ATen and the C++ API. Let's just have `at::linear` and use that everywhere. apaszke ezyang (who mentioned this in pytorch#10481) Pull Request resolved: pytorch#10755 Differential Revision: D9443881 Pulled By: goldsborough fbshipit-source-id: a64862d1649b5961043d58401625ec267d97d9f3
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Resubmission of pytorch#10755 with fix for ONNX ezyang jamesr66a Pull Request resolved: pytorch#10799 Differential Revision: D9482168 Pulled By: goldsborough fbshipit-source-id: 85d4bdfcf0d451f2e7a1c83c5f5415cdd6caacdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimized code for
linear()which usesaddmmwhen a bias is given was duplicated three times in the ATen and the C++ API. Let's just haveat::linearand use that everywhere.@apaszke @ezyang (who mentioned this in #10481)