Skip to content

Conversation

@li-roy
Copy link
Contributor

@li-roy li-roy commented Aug 21, 2018

No description provided.

@ssnl
Copy link
Collaborator

ssnl commented Aug 28, 2018

Windows CI failure looks possibly relevant.

Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool -- so what end to end test still need fixes to work?

test/test_jit.py Outdated

This comment was marked as off-topic.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@li-roy
Copy link
Contributor Author

li-roy commented Aug 30, 2018

@pytorchbot retest this please

1 similar comment
@li-roy
Copy link
Contributor Author

li-roy commented Aug 30, 2018

@pytorchbot retest this please

@li-roy
Copy link
Contributor Author

li-roy commented Aug 30, 2018

@zdevito test_time_sequence_prediction still has a couple of python ops that we can't get rid of as is.

This PR also doesn't enable test_neural_style but I have a fix for that coming.

@zdevito zdevito added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 30, 2018
@li-roy
Copy link
Contributor Author

li-roy commented Sep 5, 2018

@pytorchbot retest this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
Summary: Pull Request resolved: pytorch#10717

Differential Revision: D9562888

Pulled By: li-roy

fbshipit-source-id: 8f5d62fd0a44aca0a41dc10438e7bb91cc2a972a
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants