Remove regex matching from undefined_tensor_test #10702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsrmath
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
approved these changes
Aug 20, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
jsrmath has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@jsrmath BTW, your commit message should explain why you are doing this, e.g., by referencing the relevant GH issue. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 22, 2018
Summary: Don't regex against strings that may have come from the backtrace. Better to just not regex at all. Pull Request resolved: pytorch/pytorch#10702 Reviewed By: ezyang Differential Revision: D9406154 Pulled By: jsrmath fbshipit-source-id: 9b17abee2a6e737a32c05f1e3963aef4b6638a47
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…pytorch#10702) Summary: Don't regex against strings that may have come from the backtrace. Better to just not regex at all. Pull Request resolved: pytorch#10702 Reviewed By: ezyang Differential Revision: D9406154 Pulled By: jsrmath fbshipit-source-id: 9b17abee2a6e737a32c05f1e3963aef4b6638a47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.