[ATen] Update pre-compiled header #106915
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106915
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit a70e5d4 with merge base d395088 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@peterbell10 your PR has been successfully reverted. |
This reverts commit 4f3284e. Reverted #106915 on behalf of https://github.com/ZainRizvi due to reverting the full stack. I missed that the iostream pr was stacked under this one and it's builds are also failing internally ([comment](#106915 (comment)))
|
Depending on implicit imports for a pre-compiled header is really bad practice, there should ideally be a CI job building without PCH to prevent that. |
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I'm re-landing the stack, internal builds look fine to me now. |
|
@pytorchbot merge -f "Re-landing after ghfirst revert" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: #106915 Approved by: https://github.com/lezcano ghstack dependencies: #106914
|
@pytorchbot revert -m "Unfortunately there is still a breaking Metal job due to the bottom PR. @kit1980 will help fix this and get this merged" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@peterbell10 your PR has been successfully reverted. |
This reverts commit c68d0a7. Reverted #106915 on behalf of https://github.com/osalpekar due to Unfortunately there is still a breaking Metal job due to the bottom PR. @kit1980 will help fix this and get this merged ([comment](#106915 (comment)))
Summary: Replaced by std::array Test Plan: Sandcastle Differential Revision: D48160261 Pull Request resolved: #106810 Approved by: https://github.com/peterbell10
This reverts commit 39297eb. Reverted #106810 on behalf of https://github.com/huydhn due to Sorry for reverting your PR but the build is failing precompiled header build in trunk due to a landrace with the revert of #106915 ([comment](#106810 (comment)))
Stack from ghstack (oldest at bottom):
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10