[inductor] Call render() once for templates #105987
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105987
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b236195: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
I feel like this makes more sense to me, but now that I've understood the templating system I am no longer a neutral observer :) |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
This is more code, but perhaps easier to understand? Both Chillee and ipiszy expressed confusion that we rendered templates twice to reach a fixed point. This removes that. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
|
Successfully rebased |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This is more code, but perhaps easier to understand? Both @Chillee and @ipiszy expressed confusion that we rendered templates twice to reach a fixed point. This removes that. Pull Request resolved: pytorch#105987 Approved by: https://github.com/Chillee
Stack from ghstack (oldest at bottom):
This is more code, but perhaps easier to understand? Both @Chillee and @ipiszy expressed confusion that we rendered templates twice to reach a fixed point. This removes that.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov