reroute tensor feature in core.Net and generate one net feature in model_helper #10528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del_helper Summary: adding 2 features to core and model_helper - reroute_tensor which supports op insertion on net level - model_helper complete net and cut net used for full graph analysis Differential Revision: D9330345 fbshipit-source-id: 52abf3fad6ae5c70bdf3d7fc23a3d65137d720e9
harouwu
requested review from
Yangqing,
aazzolini,
ajtulloch,
bddppq,
dzhulgakov and
jerryzh168
Maratyszcza
reviewed
Aug 15, 2018
| op_id_mask=None, | ||
| remap_funcs=None, | ||
| keep_schema=True | ||
| keep_schema=True, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Maratyszcza
approved these changes
Aug 15, 2018
Contributor
Maratyszcza
left a comment
Maratyszcza
left a comment
There was a problem hiding this comment.
Not familiar with this part of Caffe2, but LG on the surface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
adding 2 features to core and model_helper
Differential Revision: D9330345