Skip to content

Conversation

@BLOrange-AMD
Copy link
Contributor

@BLOrange-AMD BLOrange-AMD commented Jul 12, 2023

@BLOrange-AMD BLOrange-AMD requested a review from a team as a code owner July 12, 2023 18:20
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 12, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105076

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c24a033:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Jul 12, 2023
@jithunnair-amd jithunnair-amd marked this pull request as draft July 13, 2023 06:32
@jithunnair-amd jithunnair-amd added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jul 13, 2023
@jithunnair-amd
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased upgrade_nightly_wheels_to_rocm5.6 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout upgrade_nightly_wheels_to_rocm5.6 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the upgrade_nightly_wheels_to_rocm5.6 branch from 2440b76 to 196845b Compare July 13, 2023 18:35
@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Jul 15, 2023

@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Jul 17, 2023

@BLOrange-AMD Builder PR 1442 is merged, can you please update this PR removing the temporary changes to use that PR branch?

@jithunnair-amd jithunnair-amd marked this pull request as ready for review July 18, 2023 05:17
@jithunnair-amd
Copy link
Collaborator

@atalman @malfet Ready to merge. ROCm binary CI runs passed.

@jithunnair-amd jithunnair-amd requested review from atalman and malfet July 18, 2023 15:21
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jithunnair-amd
Copy link
Collaborator

@pytorchbot merge -f "ROCm binary CI jobs passed; other CI failures unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Murat-U-Saglam
Copy link

Hi,

I have been following this thread. How can I locally pull ROCM 5.6 version support?

pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm5.6 seems to not be working

@voidanix
Copy link

How can I locally pull ROCM 5.6 version support?

Try again, the wheels should now be available.

@Murat-U-Saglam
Copy link

Murat-U-Saglam commented Jul 20, 2023

I've uninstalled torch and its artifacts (torchvision and torch audio). I've attempted to install them one by one

pip3 install --pre torch  --index-url https://download.pytorch.org/whl/nightly/rocm5.6
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
ultralytics 8.0.132 requires torchvision>=0.8.1, which is not installed.

and all together

pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm5.6
ERROR: Could not find a version that satisfies the requirement torchvision (from versions: none)
ERROR: No matching distribution found for torchvision

I believe this is not intended behaviour. How would you recommend the installation should take place?

@javiersc1
Copy link

Same issue as @Murat-U-Saglam above, unsure how to proceed.

@kuroy
Copy link

kuroy commented Jul 21, 2023

https://download.pytorch.org/whl/nightly/rocm5.6/ contains "torch" but doesn't contains "torchvision" , "torchaudio" etc, at current time(my comment's timestamp).
In other hand, https://download.pytorch.org/whl/nightly/rocm5.5/ contains "torch" "torchaudio" "torchvison" and "torchtext", so you'll succeed if you change "--index-url .." part to rocm 5.5.
You should wait until those libraries for rocm5.6 if you really requires them, or remove "torchvision" and "torchaudio" from pip3 install.. command line.

@Murat-U-Saglam
Copy link

Is there a Pull request we can follow for PyTorch vision using rocm 5.6?

@jithunnair-amd
Copy link
Collaborator

Is there a Pull request we can follow for PyTorch vision using rocm 5.6?

pytorch/test-infra#4401

atalman pushed a commit to pytorch/test-infra that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support rocm 5.6 ASAP

9 participants