[export] Fix serialize nn_module_stack #104721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

angelayi wants to merge 1 commit into pytorch:main from angelayi:export-D47252881

Contributor

angelayi commented Jul 6, 2023

Summary:
Some serialized nn_module_stacks contain nested commas, something like:
(getitem(L['module'],0),torch.nn.modules.linear.Linear)
Fixing the parsing so that we can deserialize the string in the format of: (local identifier, module type)

Test Plan: CI

Differential Revision: D47252881

pytorch-bot bot commented Jul 6, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104721

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1f8cbc2:

NEW FAILURE - The following job has failed:

manywheel-py3_8-cuda12_1-with-pypi-cudnn-test / test (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions bot added the module: export label

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jul 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47252881

angelayi requested a review from zhxchen17

July 6, 2023 19:03

angelayi added the topic: not user facing label

zhxchen17 approved these changes

View reviewed changes

Contributor

zhxchen17 left a comment

what's up with CI?

angelayi force-pushed the export-D47252881 branch from 464c179 to b8f7c57 Compare

July 6, 2023 21:51

Contributor

facebook-github-bot commented Jul 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47252881

angelayi force-pushed the export-D47252881 branch from b8f7c57 to f090c32 Compare

July 6, 2023 22:00

Contributor

facebook-github-bot commented Jul 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47252881

angelayi force-pushed the export-D47252881 branch from f090c32 to 11e6665 Compare

July 6, 2023 22:07

Contributor

facebook-github-bot commented Jul 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47252881


          [export] Fix serialize nn_module_stack (pytorch#104721)

1f8cbc2

Summary:
Pull Request resolved: pytorch#104721

Some serialized nn_module_stacks contain nested commas, something like:
`(getitem(L['module'],0),torch.nn.modules.linear.Linear)`
Fixing the parsing so that we can deserialize the string in the format of: `(local identifier, module type)`

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D47252881

fbshipit-source-id: 5094b9c183d52c8d708e7e30c2de6b622fc0e7ea

angelayi force-pushed the export-D47252881 branch from 11e6665 to 1f8cbc2 Compare

July 6, 2023 22:16

Contributor

facebook-github-bot commented Jul 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47252881

Contributor

facebook-github-bot commented Jul 7, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jul 7, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

29c30b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged topic: not user facing