Update Im2Col related to make preparation for group conv in NHWC order. #10439
Conversation
|
@pytorchbot retest this please |
2 similar comments
|
@pytorchbot retest this please |
|
@pytorchbot retest this please |
xiaomengy
force-pushed
the
export-D9285344
branch
from
efb58a0 to
0581db7
Compare
xiaomengy
force-pushed
the
export-D9285344
branch
from
0581db7 to
16d9b0b
Compare
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
LGTM, no need to do the loop on the group, which is great.
caffe2/utils/math_cpu.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caffe2/utils/math_utils.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
xiaomengy
force-pushed
the
export-D9285344
branch
from
16d9b0b to
17b32bd
Compare
|
@BIT-silence thanks for the PR. This should help what I'm working on a lot. One comment. Using batched gemm for group convolution in NHCW definitely increases parallelism a lot, but at the same time it increases working set size (we're generating G times bigger col_buffer) so I think we should check how it affects the performance. CC @ajtulloch |
caffe2/utils/math.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…r. (pytorch#10439) Summary: Pull Request resolved: pytorch#10439 Update Im2Col related to make preparation for group conv in NHWC order. Reviewed By: houseroad Differential Revision: D9285344 fbshipit-source-id: eb4c581daf3e95050de6d8b1bdaf567164e7e1cd
xiaomengy
force-pushed
the
export-D9285344
branch
from
17b32bd to
9478994
Compare
5 participants
Summary: Update Im2Col related to make preparation for group conv in NHWC order.
Differential Revision: D9285344