Remove TH compatibility calls for strides. #10414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does the following: 1) Delete USE_TH_SCALAR ifdefs, since this is now enabled. 2) sizes_, strides_ in THTensor are always at least size 1 (and may have is_zero_dim_ set). A future PR will remove is_zero_dim_, so sizes_ and strides_ will just be size 0. 3) Allow IntList sizes with nullptr; this wasn't allowed previously because sizes were always at least size 1 in TH. 4) Get rid of get_intlist_size_th compatibility call in ATen; we now just use the IntList size directly. We still use the stride compatibility call; a future PR will remove this. 5) Fix a case in TensorIterator where a tensor was resized with shape length 0 and stride length 1.
This should "just work" now that sizes/strides are unified between TH and ATen.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
This is stacked on top of #10412; the correct review to do is https://github.com/pytorch/pytorch/pull/10414/commits/92659bc54baf8f608682c307167792224f26762f..HEAD. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Aug 10, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 10, 2018
Summary: This should just work now that sizes/strides are unified between TH and ATen. Pull Request resolved: pytorch/pytorch#10414 Differential Revision: D9274681 Pulled By: gchanan fbshipit-source-id: 69eb766f4e3a5b6c57b15837cffdef513b6d7817
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This should just work now that sizes/strides are unified between TH and ATen. Pull Request resolved: pytorch#10414 Differential Revision: D9274681 Pulled By: gchanan fbshipit-source-id: 69eb766f4e3a5b6c57b15837cffdef513b6d7817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should just work now that sizes/strides are unified between TH and ATen.