[TESTING] enable zero dimensional tensors in TH. #10383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we had 0-dim tensors in TH, we were flexible in what we accepted wrt to the difference between size [] and size [1] tensors because they were identical in TH. This often masks shape issues and IMO isn't worth keeping.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 10, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 10, 2018
Summary: This issue was exposed in pytorch/pytorch#10383. Pull Request resolved: pytorch/pytorch#10388 Differential Revision: D9255836 Pulled By: gchanan fbshipit-source-id: 88c5a6415c27d56ff54d00a8957fdc1617cfbde7
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This issue was exposed in pytorch#10383. Pull Request resolved: pytorch#10388 Differential Revision: D9255836 Pulled By: gchanan fbshipit-source-id: 88c5a6415c27d56ff54d00a8957fdc1617cfbde7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.