Avoid std::thread ctor "cannot resolve" error #10381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
SsnL has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Aug 9, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 9, 2018
Summary: If an `at::test` function is added, gcc can't figure out the `std::thread(test, -1)` resolution. It is not a problem for current code. I bumped into this when playing with native functions. But I think it is a good to just prevent it from happening in future by removing `using namespace at;`. Pull Request resolved: pytorch/pytorch#10381 Differential Revision: D9241614 Pulled By: SsnL fbshipit-source-id: 972ac3cecff3a50602b3fba463ae1ebd3f53d036
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: If an `at::test` function is added, gcc can't figure out the `std::thread(test, -1)` resolution. It is not a problem for current code. I bumped into this when playing with native functions. But I think it is a good to just prevent it from happening in future by removing `using namespace at;`. Pull Request resolved: pytorch#10381 Differential Revision: D9241614 Pulled By: SsnL fbshipit-source-id: 972ac3cecff3a50602b3fba463ae1ebd3f53d036
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: If an `at::test` function is added, gcc can't figure out the `std::thread(test, -1)` resolution. It is not a problem for current code. I bumped into this when playing with native functions. But I think it is a good to just prevent it from happening in future by removing `using namespace at;`. Pull Request resolved: pytorch#10381 Differential Revision: D9241614 Pulled By: SsnL fbshipit-source-id: 972ac3cecff3a50602b3fba463ae1ebd3f53d036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
at::testfunction is added, gcc can't figure out thestd::thread(test, -1)resolution.It is not a problem for current code. I bumped into this when playing with native functions. But I think it is good to just prevent it from happening in future by removing
using namespace at;, especially considering that it is a simple change.