Don't copy on clamp, clamp_out #10352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes clamp and relu faster (fixes pytorch#10276). The extra copying was introduced when clamp moved to ATen and the _th_clamp_ wrapper was used to forward to TH/THC, we remove that and add _th_clamp(_out) instead.
t-vi
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
SsnL has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ssnl
approved these changes
Aug 9, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
SsnL is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 9, 2018
Summary: This makes clamp and relu faster (fixes #10276). The extra copying was introduced when clamp moved to ATen and the _th_clamp_ wrapper was used to forward to TH/THC, we remove that and add _th_clamp(_out) instead. Pull Request resolved: pytorch/pytorch#10352 Reviewed By: ezyang Differential Revision: D9233590 Pulled By: SsnL fbshipit-source-id: 4f86a045498e5e577fb22656c71f171add7ed0ac
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: This makes clamp and relu faster (fixes pytorch#10276). The extra copying was introduced when clamp moved to ATen and the _th_clamp_ wrapper was used to forward to TH/THC, we remove that and add _th_clamp(_out) instead. Pull Request resolved: pytorch#10352 Reviewed By: ezyang Differential Revision: D9233590 Pulled By: SsnL fbshipit-source-id: 4f86a045498e5e577fb22656c71f171add7ed0ac
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This makes clamp and relu faster (fixes pytorch#10276). The extra copying was introduced when clamp moved to ATen and the _th_clamp_ wrapper was used to forward to TH/THC, we remove that and add _th_clamp(_out) instead. Pull Request resolved: pytorch#10352 Reviewed By: ezyang Differential Revision: D9233590 Pulled By: SsnL fbshipit-source-id: 4f86a045498e5e577fb22656c71f171add7ed0ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes clamp and relu faster (fixes #10276).
The extra copying was introduced when clamp moved to ATen and
the th_clamp wrapper was used to forward to TH/THC,
we remove that and add _th_clamp(_out) instead.