[jit][script] support list slicing #10318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suo
requested review from
colesbury,
ezyang,
gchanan and
soumith
as code owners
suo
commented
Aug 7, 2018
| Operator("aten::add(Tensor[] a, Tensor[] b) -> Tensor[]", listAdd<Shared<TensorList>, at::Tensor>), | ||
|
|
||
| Operator( | ||
| "aten::slice(int[] l, int start, int end=9223372036854775807, int step=1) -> int[]", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
goldsborough
reviewed
Aug 7, 2018
torch/csrc/jit/register_prim_ops.cpp
Outdated
|
|
||
| template <typename TList, typename TElement> | ||
| Operation listSlice(Node* node) { | ||
| return [=](Stack& stack) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/register_prim_ops.cpp
Outdated
| int64_t step; | ||
|
|
||
| pop(stack, list, begin, end, step); | ||
| std::vector<TElement> sliced_list; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
apaszke
approved these changes
Aug 9, 2018
torch/csrc/jit/script/compiler.cpp
Outdated
| // Build the input arguments | ||
| std::vector<NamedValue> args = {sliceable}; | ||
| if (sliceable.value->type()->kind() == TypeKind::DynamicType) { | ||
| // If the sliceable opject is a tensor, specify a default dimension |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
michaelsuo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: As title. Pull Request resolved: pytorch#10318 Differential Revision: D9254351 Pulled By: michaelsuo fbshipit-source-id: be891a584dc295b5e353f7f5257d64a356fb9586
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: As title. Pull Request resolved: pytorch#10318 Differential Revision: D9254351 Pulled By: michaelsuo fbshipit-source-id: be891a584dc295b5e353f7f5257d64a356fb9586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.