Handle recursive tuple in clone_inputs#102979
Closed
ezyang wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102979
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 11f02ef: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
Bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
voznesenskym and
wconstab
June 5, 2023 16:22
wconstab
approved these changes
Jun 5, 2023
Contributor
Author
|
@pytorchbot merge -ic |
Collaborator
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
ezyang
added a commit
that referenced
this pull request
Jun 5, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -ic |
Collaborator
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-bionic-py3.8-clang9 / test (dynamo, 2, 2, linux.2xlarge), pull / linux-bionic-py3.11-clang9 / test (dynamo, 1, 2, linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ezyang
added a commit
that referenced
this pull request
Jun 5, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy bertmaher [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 5, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy bertmaher [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 5, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 7838c84 Pull Request resolved: #103009
ezyang
added a commit
that referenced
this pull request
Jun 6, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy bertmaher [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 6, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy bertmaher [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 6, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy bertmaher [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 6, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy bertmaher [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Jun 6, 2023
This is not actually enabled in the benchmark suite as you need #103001 and also training is broken per #101160 but might as well review this part first. Contains #102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: f8c8a23 Pull Request resolved: #103009
aaronenyeshi
pushed a commit
to aaronenyeshi/pytorch
that referenced
this pull request
Jun 6, 2023
This is not actually enabled in the benchmark suite as you need pytorch#103001 and also training is broken per pytorch#101160 but might as well review this part first. Contains pytorch#102979 but I will probably rebase past that once it lands. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#103009 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang [email protected]
cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @bertmaher