Rewrite TensorImpl to use TensorTypeId. #10278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
gchanan
approved these changes
Aug 6, 2018
aten/src/ATen/Formatting.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/SparseTensorImpl.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/core/TensorTypeId.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
force-pushed
the
export-D9184060
branch
from
2a043b4 to
00ea250
Compare
ezyang
force-pushed
the
export-D9184060
branch
from
00ea250 to
6faaaf1
Compare
ezyang
force-pushed
the
export-D9184060
branch
from
6faaaf1 to
53d8042
Compare
ezyang
force-pushed
the
export-D9184060
branch
from
53d8042 to
8fbbe39
Compare
fbshipit-source-id: 5960605c2abdf93e758cabb5605413457f96b251
Summary: Pull Request resolved: pytorch#10278 Translation to Backend happens immediately before we go into the Type universe; otherwise we use TensorTypeId. I allocated TensorTypeId corresponding exactly to existing ATen Backend. Only CPUTensorId and CUDATensorId are relevant in the Caffe2 universe. Reviewed By: gchanan Differential Revision: D9184060 fbshipit-source-id: ded568574c2db0c4503f0dc9d8c5e432608885f0
ezyang
force-pushed
the
export-D9184060
branch
from
8fbbe39 to
a5b1f72
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 13, 2018
Summary: Pull Request resolved: pytorch/pytorch#10278 Translation to Backend happens immediately before we go into the Type universe; otherwise we use TensorTypeId. I allocated TensorTypeId corresponding exactly to existing ATen Backend. Only CPUTensorId and CUDATensorId are relevant in the Caffe2 universe. Reviewed By: gchanan Differential Revision: D9184060 fbshipit-source-id: 9d3989c26f70b90f1bbf98b2a96c57e2b0a46597
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10278 Translation to Backend happens immediately before we go into the Type universe; otherwise we use TensorTypeId. I allocated TensorTypeId corresponding exactly to existing ATen Backend. Only CPUTensorId and CUDATensorId are relevant in the Caffe2 universe. Reviewed By: gchanan Differential Revision: D9184060 fbshipit-source-id: 9d3989c26f70b90f1bbf98b2a96c57e2b0a46597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Translation to Backend happens immediately before we go into the
Type universe; otherwise we use TensorTypeId.
I allocated TensorTypeId corresponding exactly to existing ATen
Backend. Only CPUTensorId and CUDATensorId are relevant in the
Caffe2 universe.
Differential Revision: D9184060