s/DISABLE_COPY_AND_ASSIGN/AT_DISABLE_COPY_AND_ASSIGN/ #10275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9157408 fbshipit-source-id: b88537159fa590be7893d8ebacbd657ba4c0a647
…/core Summary: Auxiliary changes that were needed: - Add DISABLE_COPY_AND_ASSIGN to CoreAPI.h (maybe we should rename this file now) Differential Revision: D9181321 fbshipit-source-id: 977d47cb7632dfc41461bf6f6dbdab532f3aea51
Summary: Since we now have DISABLE_COPY_AND_ASSIGN macro in the file, CoreAPI is no longer an accurate name. Differential Revision: D9181687 fbshipit-source-id: b4594a8987f45eeb3ad8b8bdeeeb537e5c8e4e7f
Summary: Good C++ libraries don't take up un-namespaced identifiers like DISABLE_COPY_AND_ASSIGN. Re-prefix this. Follow up fix: codemod Caffe2 to use the new macro, delete the forwarding definition Differential Revision: D9181939 fbshipit-source-id: 79ce403b842072bcae814c4bf610197d15a26d4e
Summary: Remove forwarding declaration in caffe2/core/common.h ``` codemod -d caffe2 --extensions cc,cpp,cu,cuh,h \\bDISABLE_COPY_AND_ASSIGN AT_DISABLE_COPY_AND_ASSIGN ``` Differential Revision: D9184809 fbshipit-source-id: 7d2b086b4555beffc91efeebaad685e41ed2070b
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: Pull Request resolved: pytorch#10275 Remove forwarding declaration in caffe2/core/common.h ``` codemod -d caffe2 --extensions cc,cpp,cu,cuh,h \\bDISABLE_COPY_AND_ASSIGN AT_DISABLE_COPY_AND_ASSIGN ``` Reviewed By: mingzhe09088 Differential Revision: D9184809 fbshipit-source-id: 958cf5162b0d92b83ea9c2597abb77320ca57ce8
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10275 Remove forwarding declaration in caffe2/core/common.h ``` codemod -d caffe2 --extensions cc,cpp,cu,cuh,h \\bDISABLE_COPY_AND_ASSIGN AT_DISABLE_COPY_AND_ASSIGN ``` Reviewed By: mingzhe09088 Differential Revision: D9184809 fbshipit-source-id: 958cf5162b0d92b83ea9c2597abb77320ca57ce8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove forwarding declaration in caffe2/core/common.h
Differential Revision: D9184809