thread BUILD_SHARED_LIBS through build_pytorch_libs.sh #10272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderspapitto
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
approved these changes
Aug 6, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
I wonder if this will work with ROCm.
anderspapitto
force-pushed
the
static-libtorch
branch
from
7c71545 to
d392b3a
Compare
Contributor
|
Nicely done! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
anderspapitto is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anderspapitto
force-pushed
the
static-libtorch
branch
from
d392b3a to
b6b2d63
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
anderspapitto is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10272 Differential Revision: D9239337 Pulled By: anderspapitto fbshipit-source-id: 187b3acb7e85635d9b45a3dd82c98d86a2b51e70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.