Skip to content

Conversation

@cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented Aug 6, 2018

fixes #10241

@cpuhrsch
Copy link
Contributor Author

cpuhrsch commented Aug 6, 2018

Coming up: extended test coverage

@soumith soumith changed the title Fix for Issue 10241 Fixes torch.log after torch.expand giving incorrect results Aug 6, 2018
@ailzhang
Copy link
Contributor

ailzhang commented Aug 6, 2018

Actually I was looking at a similar issue thus this PR also fixes #10118 and #9521

ezyang
ezyang previously requested changes Aug 6, 2018
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for test

@ezyang
Copy link
Contributor

ezyang commented Aug 7, 2018

@pytorchbot retest this please

@cpuhrsch cpuhrsch force-pushed the zerostrideapply branch 2 times, most recently from 34593c0 to 832985b Compare August 9, 2018 19:44
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 10, 2018
Summary:
fixes #10241
Pull Request resolved: pytorch/pytorch#10269

Differential Revision: D9272472

Pulled By: cpuhrsch

fbshipit-source-id: cd1afbb4386a0d0956ee21b24f0d529755b986ca
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
…10269)

Summary:
fixes pytorch#10241
Pull Request resolved: pytorch#10269

Differential Revision: D9272472

Pulled By: cpuhrsch

fbshipit-source-id: cd1afbb4386a0d0956ee21b24f0d529755b986ca
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applying torch.log after torch.expand gives incorrect results on CPU

5 participants