Add back THTensor_nDimension. #10259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out some people are using this via the C-API.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
CC @alsrgv. |
ezyang
approved these changes
Aug 6, 2018
Contributor
|
I do wonder how we're going to prevent people from using these functions, but I guess we can cross that bridge when we get there. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 6, 2018
Summary: Turns out some people are using this via the C-API. Pull Request resolved: pytorch/pytorch#10259 Differential Revision: D9180135 Pulled By: gchanan fbshipit-source-id: 68f59beabf7f8093e67581d7e7ebfe8dff9e6b69
|
Thanks for adding it back! |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Turns out some people are using this via the C-API. Pull Request resolved: pytorch#10259 Differential Revision: D9180135 Pulled By: gchanan fbshipit-source-id: 68f59beabf7f8093e67581d7e7ebfe8dff9e6b69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out some people are using this via the C-API.