Optimize group_norm on cpu #10246
Closed
Optimize group_norm on cpu #10246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseroad
reviewed
Aug 6, 2018
caffe2/operators/group_norm_op.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
approved these changes
Aug 6, 2018
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
LGTM, nit in the inline comments
Summary: Pull Request resolved: pytorch#10246 Optimize group_norm on cpu Reviewed By: houseroad Differential Revision: D9177878 fbshipit-source-id: 581ac9d90deff385813b50b19e523c254718506c
xiaomengy
force-pushed
the
export-D9177878
branch
from
60f3b8d to
2460454
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10246 Optimize group_norm on cpu Reviewed By: houseroad Differential Revision: D9177878 fbshipit-source-id: 41f7aadc6336317c338c75daccef6cb98e9de9de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Optimize group_norm on cpu
Differential Revision: D9177878