Skip to content

Conversation

@BLOrange-AMD
Copy link
Contributor

@BLOrange-AMD BLOrange-AMD commented May 25, 2023

@BLOrange-AMD BLOrange-AMD requested a review from a team as a code owner May 25, 2023 02:54
@pytorch-bot
Copy link

pytorch-bot bot commented May 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102242

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ce0d178:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels May 25, 2023
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 25, 2023
@jithunnair-amd jithunnair-amd added the ciflow/binaries Trigger all binary build and upload jobs on the PR label May 30, 2023
@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented May 30, 2023

@malfet @atalman How do we resolve this error from https://hud.pytorch.org/pr/pytorch/pytorch/102242#13868719553?

2023-05-30T17:48:22.6114673Z + pip install /final_pkgs/torch-2.1.0.dev20230530+rocm5.5-cp38-cp38-linux_x86_64.whl --index-url https://download.pytorch.org/whl/nightly/rocm5.5
2023-05-30T17:48:23.8154922Z Looking in indexes: https://download.pytorch.org/whl/nightly/rocm5.5
2023-05-30T17:48:23.8236191Z Processing /final_pkgs/torch-2.1.0.dev20230530+rocm5.5-cp38-cp38-linux_x86_64.whl
2023-05-30T17:48:27.3894700Z INFO: pip is looking at multiple versions of torch to determine which version is compatible with other requirements. This could take a while.
2023-05-30T17:48:27.3896933Z ERROR: Could not find a version that satisfies the requirement filelock (from torch) (from versions: none)
2023-05-30T17:48:27.3898297Z ERROR: No matching distribution found for filelock

Is there another step needed to upload all the dependency packages to that link?

@atalman
Copy link
Contributor

atalman commented May 31, 2023

@malfet @atalman How do we resolve this error from https://hud.pytorch.org/pr/pytorch/pytorch/102242#13868719553?

2023-05-30T17:48:22.6114673Z + pip install /final_pkgs/torch-2.1.0.dev20230530+rocm5.5-cp38-cp38-linux_x86_64.whl --index-url https://download.pytorch.org/whl/nightly/rocm5.5
2023-05-30T17:48:23.8154922Z Looking in indexes: https://download.pytorch.org/whl/nightly/rocm5.5
2023-05-30T17:48:23.8236191Z Processing /final_pkgs/torch-2.1.0.dev20230530+rocm5.5-cp38-cp38-linux_x86_64.whl
2023-05-30T17:48:27.3894700Z INFO: pip is looking at multiple versions of torch to determine which version is compatible with other requirements. This could take a while.
2023-05-30T17:48:27.3896933Z ERROR: Could not find a version that satisfies the requirement filelock (from torch) (from versions: none)
2023-05-30T17:48:27.3898297Z ERROR: No matching distribution found for filelock

Is there another step needed to upload all the dependency packages to that link?

This should be resolved now. I created the rocm5.5 path manually this time

@malfet
Copy link
Contributor

malfet commented Jun 1, 2023

I think that's a chicken an egg problem with added trition dependency: one needs to have at least one nightly for the build to succeed...

@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Jun 1, 2023

@malfet @atalman Is it possible to kick off the push of libtorch docker images to dockerhub? I was able to successfully build them post-PR-merge (https://github.com/pytorch/builder/actions/runs/5017295865/jobs/9220705416), but I don't know how to trigger a push to dockerhub.

@malfet
Copy link
Contributor

malfet commented Jun 6, 2023

@malfet @atalman Is it possible to kick off the push of libtorch docker images to dockerhub? I was able to successfully build them post-PR-merge (https://github.com/pytorch/builder/actions/runs/5017295865/jobs/9220705416), but I don't know how to trigger a push to dockerhub.

@jithunnair-amd I don't think CI relies on anything published to hub.docker.com for the last year or so. Once companion PR has been merrged on builder, docker containers should have been populated to AWS ECR/ghcr.io

@jithunnair-amd
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased upgrade_nightly_wheels_to_rocm5.5 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout upgrade_nightly_wheels_to_rocm5.5 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the upgrade_nightly_wheels_to_rocm5.5 branch from dd8f45c to 3113710 Compare June 8, 2023 22:27
@jithunnair-amd jithunnair-amd marked this pull request as draft June 9, 2023 15:46
@jithunnair-amd
Copy link
Collaborator

Now using this PR to test pytorch/builder#1421

@jithunnair-amd
Copy link
Collaborator

@pytorchbot drci

@jithunnair-amd
Copy link
Collaborator

All ROCm build jobs passed
@pytorchbot merge -ic

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 12, 2023

-ic flag is deprecated, please use -i instead for the same effect.

@jithunnair-amd
Copy link
Collaborator

All ROCm build jobs passed
@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 12, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants