Skip to content

Use serialization container in ir import export #10191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
li-roy wants to merge 7 commits into from
Closed

Use serialization container in ir import export #10191

li-roy wants to merge 7 commits into from

Conversation

@li-roy
Copy link
Contributor

@li-roy li-roy commented Aug 3, 2018

  • use serialization container in ir import export
  • change old graph export import tests to use modules
  • delete graph import code

facebook-github-bot
facebook-github-bot reviewed Aug 3, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@li-roy
Copy link
Contributor Author

li-roy commented Aug 3, 2018

@pytorchbot retest this please

zdevito
zdevito reviewed Aug 3, 2018
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I only have minor API naming comments.

test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/export.cpp Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/export.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/script/init.cpp Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/python_ir.cpp Outdated

This comment was marked as off-topic.

Sign in to view

apaszke
apaszke reviewed Aug 6, 2018
View reviewed changes
test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Aug 6, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 6, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito
zdevito approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@li-roy li-roy closed this Aug 10, 2018
@li-roy li-roy mentioned this pull request Aug 10, 2018
Closed
facebook-github-bot pushed a commit that referenced this pull request Aug 10, 2018
@facebook-github-bot
Use serialization container in ir import export (#10394)
e9ad743 
Summary:
Copy of #10191 because these changes didn't land with the diff.
Pull Request resolved: #10394

Differential Revision: D9260816

Pulled By: li-roy

fbshipit-source-id: 7dc16919cfab6221fda1d44e98c5b900cfb40558
PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Aug 10, 2018
@PenghuiCheng
Use serialization container in ir import export (pytorch#10394)
ffd4b74 
Summary:
Copy of pytorch#10191 because these changes didn't land with the diff.
Pull Request resolved: pytorch#10394

Differential Revision: D9260816

Pulled By: li-roy

fbshipit-source-id: 7dc16919cfab6221fda1d44e98c5b900cfb40558
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Use serialization container in ir import export (pytorch#10394)
880c289 
Summary:
Copy of pytorch#10191 because these changes didn't land with the diff.
Pull Request resolved: pytorch#10394

Differential Revision: D9260816

Pulled By: li-roy

fbshipit-source-id: 7dc16919cfab6221fda1d44e98c5b900cfb40558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zdevito zdevito zdevito approved these changes

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

+1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@li-roy @zdevito @apaszke @facebook-github-bot