Move typeid.h to ATen/core #10163
Closed
Move typeid.h to ATen/core #10163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
Contributor
Author
|
This PR is blocked on unifying at::Error and caffe2::EnforceNotMet |
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
ezyang
changed the title
Contributor
Author
|
@pytorchbot retest this please |
Summary: Pull Request resolved: pytorch#10163 - Remove dependency on caffe2/core/common.h for ATen/core/typeid.h Unfortunately, Windows seems to rely on typeid.h including this header, so it is still included from the forwarding header caffe2/core/typeid.h - Deduplicate Demangle/DemangleType with their ATen equivalents Reviewed By: smessmer Differential Revision: D9132432 fbshipit-source-id: f816c80f7318f602e0e4ae25f429775a192158fc
Contributor
|
@ezyang on compiling the latest master, I get this error: Is this related to the |
Contributor
Author
|
Yes, it probably is related. Can you do a clean build and if that doesn't resolve it, file an issue? |
Contributor
|
Did a pull and clean build and it works. Thanks for the input! |
Contributor
Author
|
@pytorchbot retest this please |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 10, 2018
Summary: Pull Request resolved: pytorch/pytorch#10163 - Remove dependency on caffe2/core/common.h for ATen/core/typeid.h Unfortunately, Windows seems to rely on typeid.h including this header, so it is still included from the forwarding header caffe2/core/typeid.h - Deduplicate Demangle/DemangleType with their ATen equivalents Reviewed By: smessmer Differential Revision: D9132432 fbshipit-source-id: 21f2c89e58ca1e795f1b2caa316361b729a5231b
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10163 - Remove dependency on caffe2/core/common.h for ATen/core/typeid.h Unfortunately, Windows seems to rely on typeid.h including this header, so it is still included from the forwarding header caffe2/core/typeid.h - Deduplicate Demangle/DemangleType with their ATen equivalents Reviewed By: smessmer Differential Revision: D9132432 fbshipit-source-id: 21f2c89e58ca1e795f1b2caa316361b729a5231b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
necessary local header includes
Differential Revision: D9132432