Skip to content

[JIT] Python integration for custom operators #10149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
goldsborough wants to merge 4 commits into from
Closed

[JIT] Python integration for custom operators #10149

goldsborough wants to merge 4 commits into from

Conversation

@goldsborough
Copy link
Contributor

@goldsborough goldsborough commented Aug 1, 2018 •
edited
Loading

Adds the Python path to custom operators, including dynamically loading operations into Python.

@zdevito

@goldsborough goldsborough added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 1, 2018
zdevito
zdevito approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Minor fixes, and we should have tests, but otherwise ready to go.

torch/csrc/jit/init.cpp Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/ivalue.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/pybind_utils.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/pybind_utils.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/pybind_utils.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/pybind_utils.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/pybind_utils.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/python_custom_operator.cpp Outdated

This comment was marked as off-topic.

Sign in to view

@goldsborough goldsborough changed the title [WIP] Python integration for custom operators [JIT] Python integration for custom operators Aug 3, 2018
facebook-github-bot
facebook-github-bot reviewed Aug 3, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@goldsborough goldsborough mentioned this pull request Aug 3, 2018
Closed
@goldsborough
Python integration for custom ops
caea4b7 
Robust error handling for invoke

Better error messages, reversed push order, dont expose IValue::Tag

Consolidate createStack/wrapStack methods

Wrote tests for dynamic binding and argument checking
@goldsborough
Undo invokeScriptMethodFromPython update
6b5b066
@goldsborough
Fix invokeScriptMethodFromPython
90c246a
facebook-github-bot
facebook-github-bot reviewed Aug 4, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@goldsborough
Python integration for custom operators (pytorch#10149)
1e053b1 
Summary:
Adds the Python path to custom operators, including dynamically loading operations into Python.

zdevito
Pull Request resolved: pytorch#10149

Reviewed By: ezyang

Differential Revision: D9158380

Pulled By: goldsborough

fbshipit-source-id: 3edffa639e8d2959e9e80d1bd4f20ab4a1b3ca02
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zdevito zdevito zdevito approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goldsborough @zdevito @facebook-github-bot @ezyang