Skip to content

Conversation

@syed-ahmed
Copy link
Collaborator

@syed-ahmed syed-ahmed commented May 15, 2023

This PR updates NCCL submodule to 2.18.1.

@pytorch-bot
Copy link

pytorch-bot bot commented May 15, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101457

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7423980:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 15, 2023
@syed-ahmed
Copy link
Collaborator Author

@pytorchbot label ciflow/inductor ciflow/periodic

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels May 15, 2023
@syed-ahmed
Copy link
Collaborator Author

syed-ahmed commented May 17, 2023

@kwen2501 @awgu This is ready for review. The failing tests don't seem related.

@drisspg drisspg requested a review from kwen2501 May 17, 2023 17:00
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 17, 2023
@syed-ahmed
Copy link
Collaborator Author

@kwen2501 can we get this approved?

@syed-ahmed
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update-nccl onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update-nccl && git pull --rebase)

@syed-ahmed
Copy link
Collaborator Author

@pytorchbot merge -f "CI failures are not related"

@pytorch-bot
Copy link

pytorch-bot bot commented May 26, 2023

You are not authorized to force merges to this repository. Please use the regular @pytorchmergebot merge command instead

@syed-ahmed
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 26, 2023
@pytorchmergebot
Copy link
Collaborator

This PR updates submodules third_party/nccl/nccl

If those updates are intentional, please add "submodule" keyword to PR title/description.

@malfet
Copy link
Contributor

malfet commented May 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: periodic / win-vs2019-cuda11.8-py3 / test (default, 2, 4, windows.g5.4xlarge.nvidia.gpu), trunk / libtorch-linux-bionic-cuda11.8-py3.7-gcc7 / build

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor

malfet commented May 26, 2023

Please note, that compilation filers while building libtorch are real (by likely fixable by updating this container to use gcc-9 instead of gcc-7)

@atalman
Copy link
Contributor

atalman commented Jun 6, 2023

@syed-ahmed can you please rebase this PR ? I think trunk jobs are using gcc9 now: libtorch-linux-bionic-cuda11.8-py3.7-gcc9, the error you are seing now is probably resolved

@syed-ahmed
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update-nccl onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update-nccl && git pull --rebase)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 5, 2023
@github-actions github-actions bot closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants