-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Updates NCCL to 2.18.1 #101457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates NCCL to 2.18.1 #101457
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101457
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7423980: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label ciflow/inductor ciflow/periodic |
|
@kwen2501 can we get this approved? |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
8e9d064 to
bbdc2f3
Compare
|
@pytorchbot merge -f "CI failures are not related" |
|
You are not authorized to force merges to this repository. Please use the regular |
|
@pytorchbot merge |
|
This PR updates submodules third_party/nccl/nccl If those updates are intentional, please add "submodule" keyword to PR title/description. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: periodic / win-vs2019-cuda11.8-py3 / test (default, 2, 4, windows.g5.4xlarge.nvidia.gpu), trunk / libtorch-linux-bionic-cuda11.8-py3.7-gcc7 / build Details for Dev Infra teamRaised by workflow job |
|
Please note, that compilation filers while building libtorch are real (by likely fixable by updating this container to use gcc-9 instead of gcc-7) |
|
@syed-ahmed can you please rebase this PR ? I think trunk jobs are using gcc9 now: libtorch-linux-bionic-cuda11.8-py3.7-gcc9, the error you are seing now is probably resolved |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
bbdc2f3 to
7423980
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This PR updates NCCL submodule to 2.18.1.