Move halfbits2float and float2halfbits conversions to ATen. #10134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed soon because I want to move Half.h into ATen/core, and then I cannot have a TH dependency. I also took the liberty of making the code more strict-aliasing safe (this is not actually useful, since we will never built Torch with strict aliasing) by replacing pointer casts between float and unsigned with a memcpy instead. Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
requested review from
apaszke,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
colesbury
approved these changes
Aug 1, 2018
cpuhrsch
reviewed
Aug 1, 2018
|
|
||
| // Reinterpret the result bit pattern as a float | ||
| float result_float; | ||
| std::memcpy(&result_float, &result_bit, sizeof(result_float)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
reviewed
Aug 1, 2018
| { | ||
| // Reinterpret the float as a bit pattern | ||
| unsigned x; | ||
| std::memcpy(&x, &src, sizeof(x)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
approved these changes
Aug 1, 2018
Contributor
cpuhrsch
left a comment
cpuhrsch
left a comment
There was a problem hiding this comment.
LGTM aside from minor comment
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Aug 1, 2018
…10134) Summary: This will be needed soon because I want to move Half.h into ATen/core, and then I cannot have a TH dependency. I also took the liberty of making the code more strict-aliasing safe (this is not actually useful, since we will never built Torch with strict aliasing) by replacing pointer casts between float and unsigned with a memcpy instead. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#10134 Differential Revision: D9121920 fbshipit-source-id: 2ab1012d3df3b4ad39ab6d0c5b26f9779d7f3521
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 2, 2018
Summary: This will be needed soon because I want to move Half.h into ATen/core, and then I cannot have a TH dependency. I also took the liberty of making the code more strict-aliasing safe (this is not actually useful, since we will never built Torch with strict aliasing) by replacing pointer casts between float and unsigned with a memcpy instead. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#10134 Differential Revision: D9121920 Pulled By: ezyang fbshipit-source-id: 3b1f86a7c5880e8ac1a589a51f0635bb72e1fd40
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…10134) Summary: This will be needed soon because I want to move Half.h into ATen/core, and then I cannot have a TH dependency. I also took the liberty of making the code more strict-aliasing safe (this is not actually useful, since we will never built Torch with strict aliasing) by replacing pointer casts between float and unsigned with a memcpy instead. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#10134 Differential Revision: D9121920 Pulled By: ezyang fbshipit-source-id: 3b1f86a7c5880e8ac1a589a51f0635bb72e1fd40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed soon because I want to move Half.h into
ATen/core, and then I cannot have a TH dependency.
I also took the liberty of making the code more strict-aliasing
safe (this is not actually useful, since we will never built Torch
with strict aliasing) by replacing pointer casts between
float and unsigned with a memcpy instead.
Signed-off-by: Edward Z. Yang [email protected]