Move ArrayRef, Backtrace, Error, SmallVector, optional to ATen/core; … #10092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add CoreAPI Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Signed-off-by: Edward Z. Yang <[email protected]>
Signed-off-by: Edward Z. Yang <[email protected]>
Signed-off-by: Edward Z. Yang <[email protected]>
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
Author
|
@pytorchbot retest this please |
2 similar comments
Contributor
Author
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot retest this please |
Signed-off-by: Edward Z. Yang <[email protected]>
Signed-off-by: Edward Z. Yang <[email protected]>
smessmer
approved these changes
Aug 1, 2018
Contributor
smessmer
left a comment
smessmer
left a comment
There was a problem hiding this comment.
Looks good. Btw, phabricator is showing some linter errors. Can you run 'arc lint' and fix them?
| , what_(str(err, " (", source_location, ")\n", get_backtrace(/*frames_to_skip=*/2))) | ||
| {} | ||
|
|
||
| static Warning::handler_t global_warning_handler = &Warning::print_warning; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
gchanan
reviewed
Aug 1, 2018
| # but the user doesn't have to worry about it; (2) requires the user | ||
| # to set the macro themselves... but only if they don't use cmake. | ||
| # | ||
| # So, which is appropriate in our situation? One thing I do want |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
I'll handle nits in a follow up PR. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 1, 2018
…add CoreAPI (#10092) Summary: This also makes Backtrace more portable, by disabling its functionality for mobile builds as well. It also handles Caffe2 static Windows builds by introducing a new variable, AT_CORE_STATIC_WINDOWS, which must be set if you're building ATen on Windows as part of a static library. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#10092 Reviewed By: gchanan, smessmer Differential Revision: D9094393 Pulled By: ezyang fbshipit-source-id: 93281f9302bd378605a26589ae308faf1dac7df4
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…add CoreAPI (pytorch#10092) Summary: This also makes Backtrace more portable, by disabling its functionality for mobile builds as well. It also handles Caffe2 static Windows builds by introducing a new variable, AT_CORE_STATIC_WINDOWS, which must be set if you're building ATen on Windows as part of a static library. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#10092 Reviewed By: gchanan, smessmer Differential Revision: D9094393 Pulled By: ezyang fbshipit-source-id: 93281f9302bd378605a26589ae308faf1dac7df4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…add CoreAPI
Signed-off-by: Edward Z. Yang [email protected]