Re-enable empty n-dimensional empty tensor and fix parallel CPU on empty tensors #10077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These could use some autograd tests, which are coming in a later PR, but using them in autograd is probably pretty rare.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jul 31, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 1, 2018
…pty tensors (#10077) Summary: This is a combination of pytorch/pytorch#9947 (this was reverted) and pytorch/pytorch#10076. Pull Request resolved: pytorch/pytorch#10077 Differential Revision: D9087491 Pulled By: gchanan fbshipit-source-id: 9fe9905628000f2ff3e47df32533cd7d1f25a354
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…pty tensors (pytorch#10077) Summary: This is a combination of pytorch#9947 (this was reverted) and pytorch#10076. Pull Request resolved: pytorch#10077 Differential Revision: D9087491 Pulled By: gchanan fbshipit-source-id: 9fe9905628000f2ff3e47df32533cd7d1f25a354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of #9947 (this was reverted) and #10076.