Add torch.compiled_with_cxx11_abi(). #10071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returns whether PyTorch was built with _GLIBCXX_USE_CXX11_ABI=1. Test Plan: - Checked that when compiled with gcc 4.8.5, torch.compiled_with_cxx11_abi() returns False. - Checked that when compiled with gcc 5.4, torch.compiled_with_cxx11_abi() returns False.
zou3519
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith,
ssnl and
zdevito
as code owners
soumith
suggested changes
Jul 31, 2018
|
|
||
| ASSERT_TRUE(PyModule_AddObject(module, "has_mkl", at::hasMKL() ? Py_True : Py_False) == 0); | ||
|
|
||
| #ifdef _GLIBCXX_USE_CXX11_ABI |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
Jul 31, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: It returns whether PyTorch was built with _GLIBCXX_USE_CXX11_ABI=1. Fixes pytorch#8385 Pull Request resolved: pytorch#10071 Differential Revision: D9088946 Pulled By: zou3519 fbshipit-source-id: b00fd92ee340ef34f60bdd6027ceaf46dd7442c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It returns whether PyTorch was built with _GLIBCXX_USE_CXX11_ABI=1.
Fixes #8385
Test Plan:
torch.compiled_with_cxx11_abi() returns False.
torch.compiled_with_cxx11_abi() returns True
cc @soumith