Add shape inference when converting from onnx to caffe2 #10037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
force-pushed
the
add_shape_inference
branch
from
25052bc to
3e51a81
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
force-pushed
the
add_shape_inference
branch
from
3e51a81 to
dfaf877
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Otherwise, some RNN case conversion may fail. Pull Request resolved: pytorch#10037 Reviewed By: orionr Differential Revision: D9072298 Pulled By: houseroad fbshipit-source-id: 080f589eba8618719453feb15a7a494fe5380dd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, some RNN case conversion may fail.