[CustomOp] Fix lifetime semantics #100114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100114
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dbb462c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Apr 26, 2023
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests ghstack-source-id: 135ca29 Pull Request resolved: #100114
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests [ghstack-poisoned]
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests [ghstack-poisoned]
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests [ghstack-poisoned]
This PR makes a CustomOp live forever. The motivation for it living forever is that: 1. It doesn't matter to a user if it lives forever or not 2. it is a higher-level abstraction over OpOverload, and OpOverload assumes that OpOverload lives forever. The only place where it matters that CustomOp lives forever is testing: I don't want to generate random names for my CustomOp objects. To resolve the testing problem, This PR adds a CustomOp._destroy() that clears all the C++ state, including the OpOverloadPacket, that is associated with the CustomOp object. Test Plan: - existing tests [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR makes a CustomOp live forever. The motivation for it living
forever is that:
assumes that OpOverload lives forever.
The only place where it matters that CustomOp lives forever is testing:
I don't want to generate random names for my CustomOp objects. To
resolve the testing problem, This PR adds a CustomOp._destroy() that
clears all the C++ state, including the OpOverloadPacket, that is
associated with the CustomOp object.
Test Plan: