🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100094

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 23 New Failures

As of commit d565ffc:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@iremyux Hi, thank you for working on this change. I want to ask about the use of VS2022 on Windows as I see you try to use that version instead of the default 2019. Is VS2022 an absolute need to build arm64 libtorch on Windows?

The reason I'm asking the question is that using pre-installed VS2019 in our Windows AMI gives much better reliability to Windows CI than trying to reinstall a different version of MSVC every time. It's a known issue that reinstalling MSVC on the runner could fail flakily from time to time, i.e. https://github.com/pytorch/pytorch/actions/runs/4951116658/jobs/8857247229. We suspect Windows Defender screwing up the process, but not quite sure.

@huydhn
Thanks a lot for your concern and comments. As a team we are also trying to indorse VS2022 support. That's the reason why I have been working with it instead of VS2019.

• ✅ login: iremyux / name: Irem Yuksel (d16a04d, 55476e9, 7955c1b, 66848a1, 911ecb5, 71164f7, 62b6c42, da7ce8a, 1ce04c8, 843a36d, 46904ac, a20decc, 5d93b1c, 629ccb3, 4dd7723)
• ❌ The commit (d565ffc). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

@huydhn Thanks a lot for your concern and comments. As a team we are also trying to indorse VS2022 support. That's the reason why I have been working with it instead of VS2019.

I see, but please do VS2022 update in a separate PR if it's not needed as part of this change. In fact, you shouldn't install VS at all during CI as it would be done as part of the AMI pytorch/test-infra#1175.

The problem is that installing MSVC during CI is very flaky and shouldn't be done at all. You can see that some passes, some fails on your PR https://github.com/pytorch/pytorch/actions/runs/4982100435/jobs/8917275128

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.