-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Closed
Labels
module: linear algebraIssues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmulIssues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmultodoNot as important as medium or high priority tasks, but we will work on these.Not as important as medium or high priority tasks, but we will work on these.triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
It would be awesome if there were batched versions of potrf, potrs, potri, and qr. The batch Cholesky functions would be useful in MultivariateNormal, which currently uses a for loop to compute a batch of Cholesky decompositions.
It looks like Magma has batched versions of these functions. Lapack does not, but the Lapack version of this function could always use a for-loop internally.
Open to a PR?
/cc @vishwakftw @ssnl @jacobrgardner
Edit: and batched matrix inverse
Edit [vishwakftw]: Added a checklist
-
solvea.k.a.gesv(Add batched linear solver to torch.gesv() #6100) -
inverse([RFC, ready] Batched Inverse #9949) -
cholesky_solvea.k.apotrs([Ready] Make potrs batched #13453) -
choleskya.k.apotrf([Ready] Batched cholesky decomposition #14017) -
lua.k.abtrifact([ready for review] torch.btrifact for tensors with greater than 3 dimensions #14964) -
triangular_solvea.k.atrtrs(Add batched version of trtrs #18025) -
qr(Enable batched QR decomposition and add asomeoption #20689) -
lstsqa.k.agels -
lu_solvea.k.abtrisolve(Enable broadcasting of batch dimensions RHS and LHS tensors for lu_solve #24333) -
svd(Port SVD to ATen, enable batching for matrix inputs #21588) -
cholesky_inversea.k.apotri(Port cholesky_inverse from TH/THC to ATen #31275) -
det/logdet/slogdet(Allowing batching for det/logdet/slogdet operations #22909) -
symeig(Port symeig to ATen and enable batching of inputs #21858) -
pinverse(Enable batching for pinverse #26095)
satyakrishnagorti, vadimkantorov, c0nn3r, ae-foster, fritzo and 17 more
Metadata
Metadata
Assignees
Labels
module: linear algebraIssues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmulIssues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmultodoNot as important as medium or high priority tasks, but we will work on these.Not as important as medium or high priority tasks, but we will work on these.triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module