-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Closed
Description
Inspection of the code shows this is broken.
https://github.com/pytorch/pytorch/blob/master/torch/csrc/generic/serialization.cpp#L64
s/data/le_buffer.get()/
I think the corresponding code in readFileRaw is broken too. The data is read into le_buffer but then never copied into data.
It seems dangerous to support big-endian if you're not planning to test it. Maybe just rip this out and throw an exception?
Metadata
Metadata
Assignees
Labels
No labels