Skip to content

Many iOS jobs are broken due to expired cert #65988

@suo

Description

@suo

Errors look like:

error: No signing certificate "iOS Development" found: No "iOS Development" signing certificate matching team ID "**********" with a private key was found. (in target 'TestApp' from project 'TestApp'

or

error: Signing certificate is invalid. Signing certificate "Apple Development: Tao Xu (Q7PV3L5FKY)", serial number "<DVTSigningCertificateSerialNumber: 0x7ff766b8bef0>", is not valid for code signing. It may have been revoked or expired. (in target 'TestApp' from project 'TestApp')

Incident timeline (PST)

  • 9/30 11p: Failures began
  • 9/30 11p Detected by looking at HUD at around the time failures began.
  • 10/1 9:38a fix lands as 3468237

User impact

Relatively minimal, these jobs were run on master only.

Root cause

The iOS arm64 jobs will try building the static libraries together with an app to make sure they can be linked properly. Apple requires every app to signed with a valid developer account. We are currently using @xta0's account, and it needs to be refreshed every year.

Mitigation

The issue was mitigated by updating the dev certs.

Prevention/followups

  • Set some sort of regular reminder on certificate update + runbook on how to do it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    ci: sevcritical failure affecting PyTorch CItriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions