-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Closed
Labels
module: rpcRelated to RPC, distributed autograd, RRef, and distributed optimizerRelated to RPC, distributed autograd, RRef, and distributed optimizeroncall: distributedAdd this issue/PR to distributed oncall triage queueAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
📚 Documentation
Per torch.distributed.rpc.init_model_parallel function on RPC document page in master branch here, I think there are some points to revise or polish:
- the argument
worker_name_to_idis missing in doc. - The order of arguments in doc does not match the function signature, which would cause additional ambiguity or inconvenience for readers.
- I think the repr for argument
backendis too long to read, which may contain a lot of unneeded information for readers. It is arguable but it might be better to give the class a concise repr.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528
mrshenlimrshenli
Metadata
Metadata
Assignees
Labels
module: rpcRelated to RPC, distributed autograd, RRef, and distributed optimizerRelated to RPC, distributed autograd, RRef, and distributed optimizeroncall: distributedAdd this issue/PR to distributed oncall triage queueAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module