-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Closed
Labels
module: rpcRelated to RPC, distributed autograd, RRef, and distributed optimizerRelated to RPC, distributed autograd, RRef, and distributed optimizertriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🚀 Feature
#28392 is adding timeouts per RPC, but it is currently a global timeout. Per @pritamdamania87's suggestion, we should:
1.Have a timeout parameter in RpcAgent.send().
2. For user RPCs, we always fill that in with the default rpc timeout.
3. For system RPCs, it'll default to 0 (which would be infinite) unless the system RPC sets it.
4. Later we can allow the user level RPC API to specify timeouts as well.## Motivation
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528
mrshenli and pritamdamania87
Metadata
Metadata
Assignees
Labels
module: rpcRelated to RPC, distributed autograd, RRef, and distributed optimizerRelated to RPC, distributed autograd, RRef, and distributed optimizertriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module