Skip to content

namespace Reduction is not wrapped in torch namespace (C++ API) #26606

@ShahriarRezghi

Description

@ShahriarRezghi

🐛 Bug

Hi. namespace Reduction in pytorch/aten/src/ATen/core/Reduction.h is not wrapped in any namespace. Is this intentional? This can result in namespace and enum conflicts with other projects. I think that it should live inside torch namespace.

Metadata

Metadata

Assignees

No one assigned

    Labels

    better-engineeringRelatively self-contained tasks for better engineering contributorsmodule: bootcampWe plan to do a full writeup on the issue, and then get someone to do it for onboardingmodule: internalsRelated to internal abstractions in c10 and ATentriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions