Skip to content

Fix potential infinite loop in TCP store connect function #25769

New issue
New issue
Closed
Closed
Fix potential infinite loop in TCP store connect function#25769
Assignees
rohan-varma
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixoncall: distributedAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
@pietern

Description

@pietern
pietern
opened on Sep 6, 2019

🐛 Bug

The connect function in c10d (used by the TCP store) may end up retrying infinitely if in every connection attempt it gets either a ECONNREFUSED or ECONNRESET.

See #25707 (comment)

Expected behavior

It should never run longer than the timeout argument that is already passed.

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera

Metadata

Metadata

Assignees

Labels

enhancementNot as big of a feature, but technically not a bug. Should be easy to fixoncall: distributedAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions