-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Open
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixNot as big of a feature, but technically not a bug. Should be easy to fixoncall: distributedAdd this issue/PR to distributed oncall triage queueAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Per #25550, this raises a terrible error message.
Instead, we can choose to do one of two things:
- Raise a nicer error message to say it's not needed to use DDP.
- Allow this and become a non-functional pass through.
@mrshenli @zhaojuanmao @pritamdamania87 Thoughts?
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera
Metadata
Metadata
Assignees
Labels
enhancementNot as big of a feature, but technically not a bug. Should be easy to fixNot as big of a feature, but technically not a bug. Should be easy to fixoncall: distributedAdd this issue/PR to distributed oncall triage queueAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module