-
Notifications
You must be signed in to change notification settings - Fork 27.4k
[naming] Promote _LRScheduler to LRScheduler #23957
Copy link
Copy link
Closed
Labels
module: optimizerRelated to torch.optimRelated to torch.optimneeds researchWe need to decide whether or not this merits inclusion, based on research worldWe need to decide whether or not this merits inclusion, based on research worldtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
Given that it's public API and a first class concept, I think it would be nice to remove the internal-implementation-detail-suggesting underscore from the name (e.g. Optimizer has no underscore)
cc @vincentqb
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
module: optimizerRelated to torch.optimRelated to torch.optimneeds researchWe need to decide whether or not this merits inclusion, based on research worldWe need to decide whether or not this merits inclusion, based on research worldtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module