Skip to content

DDP with unused parameters and dict return value #19354

@pietern

Description

@pietern

🐛 Bug

Using DDP after #18953, with a model where not all model parameters are used in a particular iteration, and a dict return value (from forward), doesn't work.

This is a known problem and we can easily solve by adding a smarter return value scanner that deals with dicts as well (and recurses into them?).

Metadata

Metadata

Assignees

Labels

oncall: distributedAdd this issue/PR to distributed oncall triage queuetriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions