Skip to content

Check whether _cudnn_rnn_flatten_weight can avoid changing the TensorImpl or Storage pointer of tensors in weight_arr #16695

@yf225

Description

@yf225

#16305 adds checks for TensorImpl and Storage pointer equality when a function modifies its input tensors (via inplace or out-variants) in VariableType functions. However, _cudnn_rnn_flatten_weight doesn't currently pass this check because it does in-place update into weight_arr that changes its internal tensors' TensorImpl or Storage pointer. We should investigate whether it's possible to fix this and make it also pass the pointer equality check.

cc @csarofeen @ptrblck @xwang233

Metadata

Metadata

Assignees

No one assigned

    Labels

    module: assert failureThe issue involves an assert failuremodule: cudnnRelated to torch.backends.cudnn, and CuDNN supporttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions