-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Description
There is a chicken/egg problem with magma tarballs. Building magma for rocm or cuda is done in the manylinux image, for example:
pytorch/manylinux2_28-builder:rocm${DESIRED_CUDA}-main
but this image is built using a Dockerfile that calls install_magma.sh (for cuda) or install_rocm_magma.sh. These scripts just fetch the tarball. magma needs the image to exist in order to build the tarball, but for the image to build properly it needs the magma tarball. It's a circular dependency.
The recent ROCm 6.4 upgrade required 3 PRs in sequence to update the magma packages. PR 1 created the new builder image but temporarily allowed the magma tarball fetch to fail with a warning. PR 2 updated the magma workflows to add the new ROCm version. PR 3 reverted the changes from 1 and 2 while also updating the GHA nightly wheel workflows to build rocm 6.4.
- [ROCm][CI/CD] create ROCm 6.4 images, part 1, skip magma tarball #151236
- [ROCm][CI/CD] Create ROCm6.4 magma tarball #151345
- [ROCm] upgrade nightly wheels to rocm6.4 #151355
cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @seemethere @malfet @pytorch/pytorch-dev-infra
Metadata
Metadata
Labels
Type
Projects
Status
Status