-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Closed
Labels
module: mpsRelated to Apple Metal Performance Shaders frameworkRelated to Apple Metal Performance Shaders frameworktriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🚀 The feature, motivation and pitch
#129207 discovered a silent correctness issue in conv1d with output channels > 65536. A guard with an error message was added in #129484.
On macOS 15.1 it looks like this has been fixed based on testing with the repro case from #129207.
Consider adding support for output channels > 2**16 again. Discover which macOS versions are supported and keep the guard for the macOS versions where it's not supported. Add unit tests with xfails for the versions where it is still failing.
xref #134416 huggingface/parler-tts#148
Alternatives
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
module: mpsRelated to Apple Metal Performance Shaders frameworkRelated to Apple Metal Performance Shaders frameworktriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module