-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Closed
Labels
low priorityWe're unlikely to get around to doing this in the near futureWe're unlikely to get around to doing this in the near futuremodule: inductoroncall: pt2smallWe think this is a small issue to fix. Consider knocking off high priority small issuesWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
A scheduler node that has been removed from the graph (added to V.graph.removed_operations) currently will not be removed from the users variable of a SchedulerBuffer. This means that any consumers of the users variable will first have to check whether that user has been removed. This is not done in decide_inplace_update or get_read_write_buffers_sizes. Some sort of pruning step after dead_node_elimination is probably the best solution IMO.
Error logs
No response
Minified repro
No response
Versions
all
cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @aakhundov
Metadata
Metadata
Assignees
Labels
low priorityWe're unlikely to get around to doing this in the near futureWe're unlikely to get around to doing this in the near futuremodule: inductoroncall: pt2smallWe think this is a small issue to fix. Consider knocking off high priority small issuesWe think this is a small issue to fix. Consider knocking off high priority small issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module