You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Nightly MacOS wheels are no longer build with OpenMP support #123225
Activity
desertfire commentedon Apr 3, 2024
xref #122705
malfet commentedon Apr 3, 2024
Regression happen between Mar 20st and Mar 21st:
malfet commentedon Apr 3, 2024
Ok, this regression is caused by pytorch/builder#1747 which moved to newer
numpyand as result no longer installsllvm-openmpLikely fixed by pytorch/builder@47a8e4b running the builds now in https://github.com/pytorch/pytorch/actions/runs/8519101815/job/23371854491
Run tests on Linux and x86 Mac (#22)
atalman commentedon Apr 4, 2024
closing since its fixed
malfet commentedon Apr 4, 2024
Reopening as I want to understand why it was not test as this check is explicitly present in
https://github.com/pytorch/builder/blob/e2bc5c29dfb8735553bf61014e4223d6900826cf/run_tests.sh#L158
atalman commentedon Apr 11, 2024
Validated with 2.3
albanD commentedon Apr 11, 2024
Any hint on Nikita's question above on why this was missed by testing?
huydhn commentedon Apr 11, 2024
Oh, I think I figure out the reason. We don't run that test script on nightly (or release branch) at all because it has been turned off by https://github.com/pytorch/pytorch/blob/main/.github/workflows/generated-macos-arm64-binary-wheel-nightly.yml#L29. I lack the context here, maybe it was intentional and replaced by something else?
I can see that the script that Nikita mentions are called from either:
SKIP_ALL_TESTSmakes it a no-op.As the next step, I think we should either clean up that file because it's not used, or update workflows on PT to turn it back on again.
cc @atalman
albanD commentedon Apr 15, 2024
From the discussion here, it feels like we really want to re-enable it!
Re-enable nightly testing for linux and macos binaries (#123390)
Re-enable nightly testing for linux and macos binaries (pytorch#123390)
Run tests on Linux and x86 Mac (#22)
Run tests on Linux and x86 Mac (#22)
Run tests on Linux and x86 Mac (#22)
[CD] Test that all PyTorch wheels support OpenMP (pytorch#143394)