[testing] Add Opinfo for torch.frac and minor fixes (#52660)

kshitij12345 · facebook-github-bot · commit f5617b0932c7 · 2021-03-01T04:58:31.000-08:00
Summary: Reference : #42515 Pull Request resolved: #52660 Reviewed By: ailzhang Differential Revision: D26618151 Pulled By: mruberry fbshipit-source-id: cf0df38e46f44d3afff6e0015af5a840c661aa0e
diff --git a/test/test_torch.py b/test/test_torch.py
@@ -7030,7 +7030,6 @@ def tmp(dtype, device):
     ('eig', 'with_eigvec', _new_t((10, 10)), lambda t, d: [True],
         1e-5, 1e-5, 1e-5, _float_types_no_half, _cpu_types, False, [skipCUDAIfNoMagma, onlyOnCPUAndCUDA]),
     ('sign', '', _small_3d, lambda t, d: []),
-    ('frac', '', _small_3d, lambda t, d: [], 1e-5, 1e-2, 1e-5, _float_types, [torch.bfloat16]),
 ]
 
 # Creates and decorates a generic test and adds it to the class.
diff --git a/test/test_unary_ufuncs.py b/test/test_unary_ufuncs.py
@@ -52,11 +52,10 @@
                -math.pi + .00001, math.pi - .00001,
                -math.pi, math.pi,
                -math.pi - .00001, math.pi + .00001)
-_large_float_vals = (-501, 501,
-                     -1001.2, 1001.2,
-                     -13437.7, 13437.7,
-                     -4988429.2, 4988429.2,
-                     -1e20, 1e20)
+_large_float16_vals = (-501, 501,
+                       -1001.2, 1001.2,
+                       -13437.7, 13437.7)
+_large_float_vals = _large_float16_vals + (-4988429.2, 4988429.2, -1e20, 1e20)
 _float_extremals = (float('inf'), float('-inf'), float('nan'))
 _medium_length = 812
 _large_size = (1029, 917)
@@ -146,7 +145,11 @@ def generate_numeric_tensors_hard(device, dtype, *,
         return ()
 
     if dtype.is_floating_point:
-        vals = _large_float_vals
+        if dtype is torch.float16:
+            # float16 has smaller range.
+            vals = _large_float16_vals
+        else:
+            vals = _large_float_vals
     elif dtype.is_complex:
         vals = tuple(complex(x, y) for x, y in chain(product(_large_float_vals, _large_float_vals),
                                                      product(_float_vals, _large_float_vals),
@@ -1726,7 +1729,6 @@ def _medium_2d(dtype, device):
 
 # TODO: all these should be replaced with OpInfos
 torch_op_tests = [
-    _TorchMathTestMeta('frac', reffn='fmod', refargs=lambda x: (x.numpy(), 1)),
     _TorchMathTestMeta('polygamma', args=[0], substr='_0', reffn='polygamma',
                        refargs=lambda x: (0, x.numpy()), input_fn=_generate_gamma_input, inputargs=[False],
                        ref_backend='scipy'),
diff --git a/torch/testing/_internal/common_methods_invocations.py b/torch/testing/_internal/common_methods_invocations.py
@@ -1730,6 +1730,15 @@ def sample_inputs_masked_select(op_info, device, dtype, requires_grad):
            dtypesIfCUDA=all_types_and_complex_and(torch.bool, torch.half),
            sample_inputs_func=sample_inputs_diag,
            test_inplace_grad=False),
+    UnaryUfuncInfo('frac',
+                   ref=lambda x: np.modf(x)[0],
+                   dtypes=floating_types_and(torch.bfloat16, torch.float16),
+                   dtypesIfCPU=floating_types_and(torch.bfloat16, torch.float16),
+                   dtypesIfCUDA=floating_types_and(torch.float16),
+                   assert_autodiffed=True,
+                   # Reference for disabling extremals
+                   # https://github.com/pytorch/pytorch/issues/51948
+                   handles_extremals=False),
     SpectralFuncInfo('fft.fft',
                      aten_name='fft_fft',
                      ref=np.fft.fft,
@@ -2967,8 +2976,6 @@ def method_tests():
         ('rsqrt', uniform_scalar(1e-2, requires_grad=True), NO_ARGS, 'scalar', (True,)),
         ('rsqrt', torch.rand(S, S, S, dtype=torch.cfloat) + 1e-2, NO_ARGS, 'complex', (True,)),
         ('rsqrt', uniform_scalar(1e-2 * (1 + 1j), requires_grad=True), NO_ARGS, 'complex_scalar', (True,)),
-        ('frac', (S, S, S), NO_ARGS, '', (True,)),
-        ('frac', (), NO_ARGS, 'scalar', (True,)),
         ('fmod', (S, S, S), (1.5,), '', (True,)),
         ('fmod', (), (1.5,), 'scalar', (True,)),
         ('fmod', (S, S, S), (non_differentiable(torch.rand(S, S, S) + 1.5),), 'tensor'),

Original file line number	Diff line number	Diff line change
`@@ -7030,7 +7030,6 @@ def tmp(dtype, device):`
`7030`	`7030`	`('eig', 'with_eigvec', _new_t((10, 10)), lambda t, d: [True],`
`7031`	`7031`	`1e-5, 1e-5, 1e-5, _float_types_no_half, _cpu_types, False, [skipCUDAIfNoMagma, onlyOnCPUAndCUDA]),`
`7032`	`7032`	`('sign', '', _small_3d, lambda t, d: []),`
`7033`		`- ('frac', '', _small_3d, lambda t, d: [], 1e-5, 1e-2, 1e-5, _float_types, [torch.bfloat16]),`
`7034`	`7033`	`]`
`7035`	`7034`
`7036`	`7035`	`# Creates and decorates a generic test and adds it to the class.`