Skip to content

Commit c5f1117

Browse files
jeffdailyfacebook-github-bot
jeffdaily
authored and
facebook-github-bot
committed
[ROCm] remove builds for versions less than 3.8 (#48118)
Summary: Pull Request resolved: #48118 Reviewed By: zhangguanheng66 Differential Revision: D25246563 Pulled By: malfet fbshipit-source-id: cd6142286813411d542926284fbf65206bc371ae
1 parent aaf6582 commit c5f1117

File tree

5 files changed

+13
-40
lines changed

5 files changed

+13
-40
lines changed

‎.circleci/cimodel/data/pytorch_build_data.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
]),
9494
]),
9595
("rocm", [
96-
("3.7", [
96+
("3.9", [
9797
("3.6", [
9898
('build_only', [XImportant(True)]),
9999
]),

‎.circleci/cimodel/data/simple/docker_definitions.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"pytorch-linux-xenial-py3.6-gcc5.4", # this one is used in doc builds
3030
"pytorch-linux-xenial-py3.6-gcc7.2",
3131
"pytorch-linux-xenial-py3.6-gcc7",
32-
"pytorch-linux-bionic-rocm3.7-py3.6",
3332
"pytorch-linux-bionic-rocm3.8-py3.6",
3433
"pytorch-linux-bionic-rocm3.9-py3.6",
3534
]

‎.circleci/config.yml‎

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -453,12 +453,8 @@ jobs:
453453
no_output_timeout: "1h"
454454
command: |
455455
set -e
456-
# TODO: Remove this after we figure out why rocm tests are failing
457-
if [[ "${DOCKER_IMAGE}" == *rocm3.5* ]]; then
458-
export DOCKER_TAG="ab1632df-fa59-40e6-8c23-98e004f61148"
459-
fi
460-
if [[ "${DOCKER_IMAGE}" == *rocm3.7* ]]; then
461-
export DOCKER_TAG="1045c7b891104cb4fd23399eab413b6213e48aeb"
456+
if [[ "${DOCKER_IMAGE}" == *rocm3.9* ]]; then
457+
export DOCKER_TAG="f3d89a32912f62815e4feaeed47e564e887dffd6"
462458
fi
463459
if [[ ${BUILD_ENVIRONMENT} == *"pure_torch"* ]]; then
464460
echo 'BUILD_CAFFE2=OFF' >> "${BASH_ENV}"
@@ -538,12 +534,8 @@ jobs:
538534
command: |
539535
set -e
540536
export PYTHONUNBUFFERED=1
541-
# TODO: Remove this after we figure out why rocm tests are failing
542-
if [[ "${DOCKER_IMAGE}" == *rocm3.5* ]]; then
543-
export DOCKER_TAG="ab1632df-fa59-40e6-8c23-98e004f61148"
544-
fi
545-
if [[ "${DOCKER_IMAGE}" == *rocm3.7* ]]; then
546-
export DOCKER_TAG="1045c7b891104cb4fd23399eab413b6213e48aeb"
537+
if [[ "${DOCKER_IMAGE}" == *rocm3.9* ]]; then
538+
export DOCKER_TAG="f3d89a32912f62815e4feaeed47e564e887dffd6"
547539
fi
548540
# See Note [Special build images]
549541
output_image=${DOCKER_IMAGE}:${DOCKER_TAG}-${CIRCLE_SHA1}
@@ -7280,9 +7272,6 @@ workflows:
72807272
- docker_build_job:
72817273
name: "docker-pytorch-linux-xenial-py3.6-gcc7"
72827274
image_name: "pytorch-linux-xenial-py3.6-gcc7"
7283-
- docker_build_job:
7284-
name: "docker-pytorch-linux-bionic-rocm3.7-py3.6"
7285-
image_name: "pytorch-linux-bionic-rocm3.7-py3.6"
72867275
- docker_build_job:
72877276
name: "docker-pytorch-linux-bionic-rocm3.8-py3.6"
72887277
image_name: "pytorch-linux-bionic-rocm3.8-py3.6"
@@ -7713,11 +7702,11 @@ workflows:
77137702
docker_image: "308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-py3.8-gcc9"
77147703
resource_class: large
77157704
- pytorch_linux_build:
7716-
name: pytorch_linux_bionic_rocm3_7_py3_6_build
7705+
name: pytorch_linux_bionic_rocm3_9_py3_6_build
77177706
requires:
7718-
- "docker-pytorch-linux-bionic-rocm3.7-py3.6"
7719-
build_environment: "pytorch-linux-bionic-rocm3.7-py3.6-build"
7720-
docker_image: "308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-rocm3.7-py3.6"
7707+
- "docker-pytorch-linux-bionic-rocm3.9-py3.6"
7708+
build_environment: "pytorch-linux-bionic-rocm3.9-py3.6-build"
7709+
docker_image: "308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-rocm3.9-py3.6"
77217710
resource_class: xlarge
77227711
- pytorch_macos_10_13_py3_build:
77237712
name: pytorch_macos_10_13_py3_build

‎.circleci/docker/build.sh‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -274,13 +274,6 @@ case "$image" in
274274
VISION=yes
275275
KATEX=yes
276276
;;
277-
pytorch-linux-bionic-rocm3.7-py3.6)
278-
ANACONDA_PYTHON_VERSION=3.6
279-
PROTOBUF=yes
280-
DB=yes
281-
VISION=yes
282-
ROCM_VERSION=3.7
283-
;;
284277
pytorch-linux-bionic-rocm3.8-py3.6)
285278
ANACONDA_PYTHON_VERSION=3.6
286279
PROTOBUF=yes

‎.circleci/verbatim-sources/job-specs/pytorch-job-specs.yml‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,8 @@ jobs:
1515
no_output_timeout: "1h"
1616
command: |
1717
set -e
18-
# TODO: Remove this after we figure out why rocm tests are failing
19-
if [[ "${DOCKER_IMAGE}" == *rocm3.5* ]]; then
20-
export DOCKER_TAG="ab1632df-fa59-40e6-8c23-98e004f61148"
21-
fi
22-
if [[ "${DOCKER_IMAGE}" == *rocm3.7* ]]; then
23-
export DOCKER_TAG="1045c7b891104cb4fd23399eab413b6213e48aeb"
18+
if [[ "${DOCKER_IMAGE}" == *rocm3.9* ]]; then
19+
export DOCKER_TAG="f3d89a32912f62815e4feaeed47e564e887dffd6"
2420
fi
2521
if [[ ${BUILD_ENVIRONMENT} == *"pure_torch"* ]]; then
2622
echo 'BUILD_CAFFE2=OFF' >> "${BASH_ENV}"
@@ -100,12 +96,8 @@ jobs:
10096
command: |
10197
set -e
10298
export PYTHONUNBUFFERED=1
103-
# TODO: Remove this after we figure out why rocm tests are failing
104-
if [[ "${DOCKER_IMAGE}" == *rocm3.5* ]]; then
105-
export DOCKER_TAG="ab1632df-fa59-40e6-8c23-98e004f61148"
106-
fi
107-
if [[ "${DOCKER_IMAGE}" == *rocm3.7* ]]; then
108-
export DOCKER_TAG="1045c7b891104cb4fd23399eab413b6213e48aeb"
99+
if [[ "${DOCKER_IMAGE}" == *rocm3.9* ]]; then
100+
export DOCKER_TAG="f3d89a32912f62815e4feaeed47e564e887dffd6"
109101
fi
110102
# See Note [Special build images]
111103
output_image=${DOCKER_IMAGE}:${DOCKER_TAG}-${CIRCLE_SHA1}

0 commit comments

Comments
 (0)